Expose clientIdentifier generation as a function #902
Merged
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to modify it as needed
markt-asf
reviewed
Sep 25, 2025
java/org/apache/catalina/valves/CrawlerSessionManagerValve.java
Outdated
Show resolved
Hide resolved
…fier to use request parameter
Contributor
Author
|
@markt-asf |
Contributor
|
LGTM to me. I'll merge it to 12.0.x. Add a change log entry, fix anything else that needs cleaning up and then back-port. |
markt-asf
added a commit
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for custom client identifier generation, by re-implementing it as a function and allow setting it on the valve.